Add InsideHorizon trigger for worldtube excision
#6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
requested changes
Dec 11, 2024
src/Evolution/Systems/CurvedScalarWave/Worldtube/Triggers/InsideHorizon.hpp
Outdated
Show resolved
Hide resolved
Comment on lines
29
to
30
| "Triggers if the worldtube is entirely inside a coordinate sphere with " | ||
| "radius 1.99 M."; |
There was a problem hiding this comment.
Add "centered on the origin in the inertial frame".
Also, should 1.99 be an option in the input file? Does this depend on the mass of the larger black hole always being 1M?
There was a problem hiding this comment.
This does assume that the central black hole has mass 1 but that is already assumed in a few places in the code. I am hesitant to make this an input file choice as only a very small range of radii make sense here and I found 1.99 M to be a very robust choice.
src/Evolution/Systems/CurvedScalarWave/Worldtube/Triggers/InsideHorizon.cpp
Outdated
Show resolved
Hide resolved
src/Evolution/Systems/CurvedScalarWave/Worldtube/Triggers/InsideHorizon.cpp
Outdated
Show resolved
Hide resolved
src/Evolution/Systems/CurvedScalarWave/Worldtube/Triggers/InsideHorizon.cpp
Outdated
Show resolved
Hide resolved
nikwit
force-pushed
the
inside-horizon
branch
from
b38cf54 to
6f40cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the
InsideHorizontrigger, that indicates when the worldtube is entirely contained within the event horizon of the central black hole.